Configure ESLint to ignore unused args prefixed with _ #3569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been labeled as stale due to inactivity. Reply to keep this pull request open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdwith a summary of your changes _(I don't think these changes deserve to be part of the public CHANGELOG but let me know if you think otherwise @ntotten)As the title of this PR advertises, I've configure the
no-unused-varslinting rule to ignore variables whose name is prefixed by an underscore to avoid having a bunch of disable comments.I also fixed a couple more of linting errors, refer to the commit history for those one-time fixes.